iLoveElysia/pjax
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

Add cacheBust option #71

Merged
tremby merged 2 commits from add-cachebust-option into master 2016-06-27 23:46:14 -05:00
Conversation 6 Commits 2 Files Changed 5
+43 -10
tremby commented 2016-06-24 03:57:21 -05:00 (Migrated from github.com)
Copy link
Copy source

This addresses #70.

This addresses #70.
MoOx commented 2016-06-28 00:16:47 -05:00 (Migrated from github.com)
Copy link
Copy source

I was about to cut a release but got this issue locally:

# test xhr request
# - request is made, gets a result, and is cache-busted
not ok 1 Error: TypeError: 'undefined' is not an object (evaluating 'r.responseURL.indexOf') on line 12906

Any idea if that can be cause by what you did here?

I was about to cut a release but got this issue locally: ``` # test xhr request # - request is made, gets a result, and is cache-busted not ok 1 Error: TypeError: 'undefined' is not an object (evaluating 'r.responseURL.indexOf') on line 12906 ``` Any idea if that can be cause by what you did here?
MoOx commented 2016-06-28 00:17:30 -05:00 (Migrated from github.com)
Copy link
Copy source

(I think tests are running via safari on my machine, testling is choosing by itself)

(I think tests are running via safari on my machine, testling is choosing by itself)
tremby commented 2016-06-28 00:54:32 -05:00 (Migrated from github.com)
Copy link
Copy source

The tests ran OK for me in Firefox. It's possible there's a bug. I'll look into this when I get time (in the next few days), if you don't find the issue before then.

The tests ran OK for me in Firefox. It's possible there's a bug. I'll look into this when I get time (in the next few days), if you don't find the issue before then.
tremby commented 2016-07-05 02:38:23 -05:00 (Migrated from github.com)
Copy link
Copy source

It's working fine in Safari 9.1 but I can reproduce the problem in Safari 8. Looking into it.

It's working fine in Safari 9.1 but I can reproduce the problem in Safari 8. Looking into it.
tremby commented 2016-07-05 03:19:13 -05:00 (Migrated from github.com)
Copy link
Copy source

I've fixed the test for Safari 8 in #73.

I've fixed the test for Safari 8 in #73.
MoOx commented 2016-07-11 00:12:47 -05:00 (Migrated from github.com)
Copy link
Copy source

Released in 0.2.4

Released in 0.2.4
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
invalid
question
wontfix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
iLoveElysia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#71