Polyfill XHR.responseURL so tests pass in old Safari #73

2016-07-05T03:18:59-05:00

tremby commented

2016-07-05 03:18:59 -05:00

(Migrated from github.com)

This property is only used in the tests. It doesn't exist in Safari 8 and before, so where it's not available this patch polyfills it, allowing the test to continue.

tremby commented

2016-07-05 03:20:44 -05:00

(Migrated from github.com)

The pjax functionality was fine, by the way -- it was just the test which failed. The test wanted to check what URL was actually requested by the XHR, but Safari <=8 doesn't have the xhr.responseURL property. That's not used in the application code, just the tests.

The pjax functionality was fine, by the way -- it was just the test which failed. The test wanted to check what URL was actually requested by the XHR, but Safari <=8 doesn't have the `xhr.responseURL` property. That's not used in the application code, just the tests.

tremby commented

2016-07-05 03:22:01 -05:00

(Migrated from github.com)

I'll clarify as well that this polyfill is only loaded during testing, not as part of the pjax library.

MoOx commented

2016-07-11 00:12:20 -05:00

(Migrated from github.com)

I just cut 0.2.4

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#73