iLoveElysia/pjax
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

Merge pull request #49 from darylteo/patch-39

Browse Source 
[FIX] #39 - events on top level
This commit is contained in:
Maxime Thirouin
2016-01-05 07:14:17 +01:00
parent aaa2631eb7 b156a4f389
commit 2f4bd760a5
2 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/events/trigger.js
View File

@@ -16,7 +16,7 @@ module.exports = function(els, events, opts) {
forEachEls(els, function(el) { forEachEls(els, function(el) {
var domFix = false var domFix = false
if (!el.parentNode) { if (!el.parentNode && el !== document && el !== window) {
// THANKS YOU IE (9/10//11 concerned) // THANKS YOU IE (9/10//11 concerned)
// dispatchEvent doesn't work if element is not in the dom // dispatchEvent doesn't work if element is not in the dom
domFix = true domFix = true

18
tests/lib/events.js
View File

@@ -90,3 +90,21 @@ tape("test events on/off/trigger for multiple elements, multiple events", functi
t.end() t.end()
}) })
tape("test events on top level elements", function(t) {
var el = document;
el.className = ""
on(el, "click", classCb)
trigger(el, "click")
t.equal(el.className, "on", "attached callback has been fired properly on document")
el = window;
el.className = ""
on(el, "click", classCb)
trigger(el, "click")
t.equal(el.className, "on", "attached callback has been fired properly on window")
t.end()
})