iLoveElysia/pjax
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

HierarchyRequestError #39

New Issue
Closed
opened 2015-08-20 07:28:38 -05:00 by graup · 7 comments
graup commented 2015-08-20 07:28:38 -05:00 (Migrated from github.com)
Copy Link

Hi, I tried using the latest version but it breaks on a HierarchyRequestError. I tracked down the bug:

Here you call trigger(document, ...), but trigger will add the element to the DOM if it doesn't have a parentNode (which document doesn't) here. The result is a call like document.body.appendChild(document) which breaks.

After downgrading to 0.1.4 this error disappeared.

Hi, I tried using the latest version but it breaks on a HierarchyRequestError. I tracked down the bug: [Here](https://github.com/MoOx/pjax/blob/6eafcf8dc61742adfb0bc7a0f401a849366f1422/index.js#L139) you call `trigger(document, ...)`, but trigger will add the element to the DOM if it doesn't have a parentNode (which document doesn't) [here](https://github.com/MoOx/pjax/blob/6eafcf8dc61742adfb0bc7a0f401a849366f1422/lib/events/trigger.js#L23). The result is a call like `document.body.appendChild(document)` which breaks. After downgrading to 0.1.4 this error disappeared.
rstacruz commented 2015-10-04 03:57:37 -05:00 (Migrated from github.com)
Copy Link

getting this too.

getting this too.
Axure commented 2015-11-02 03:33:06 -05:00 (Migrated from github.com)
Copy Link

Me, too.

Me, too.
MoOx commented 2015-11-02 03:38:24 -05:00 (Migrated from github.com)
Copy Link

Fix as a PR is always welcome :)

Fix as a PR is always welcome :)
MoOx commented 2015-11-02 03:39:08 -05:00 (Migrated from github.com)
Copy Link

Note: I don't currently use this package and so, do not want to take time for it.

Note: I don't currently use this package and so, do not want to take time for it.
pklada commented 2015-12-17 17:25:28 -05:00 (Migrated from github.com)
Copy Link

Did this ever get fixed? Getting this too.

Did this ever get fixed? Getting this too.
👍 1 👎 1 ❤️ 1 😆 1
MoOx commented 2016-01-05 01:15:47 -05:00 (Migrated from github.com)
Copy Link

Closed by 1d292a1a6e

Closed by 1d292a1a6eeb19918304c28d31b513d05a88c086
rstacruz commented 2016-01-05 01:16:51 -05:00 (Migrated from github.com)
Copy Link

woohoo!

woohoo!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
invalid
question
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
iLoveElysia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#39
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?