iLoveElysia/pjax
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

[FIX] #39 - events on top level #49

Merged
darylteo merged 2 commits from patch-39 into master 2016-01-05 01:14:17 -05:00
Conversation 3 Commits 2 Files Changed 2 +19 -1
darylteo commented 2016-01-04 06:34:23 -05:00 (Migrated from github.com)
Copy Link

Events triggered on top level elements (such as window or document)
lead to a HierarchyRequestError due to a fix in IE browsers
where dispatchEvent does not fire if an element is not in the DOM.

The current test is simply to check for the existence of parentNode
However, this means top level elements get added to itself, causing
the error.

The proposed fix simply tests for top level elements in the test.

Events triggered on top level elements (such as window or document) lead to a HierarchyRequestError due to a fix in IE browsers where dispatchEvent does not fire if an element is not in the DOM. The current test is simply to check for the existence of parentNode However, this means top level elements get added to itself, causing the error. The proposed fix simply tests for top level elements in the test.
darylteo commented 2016-01-04 06:35:00 -05:00 (Migrated from github.com)
Copy Link

Unfortunately testling doesn't seem supported on OS X. I will try to figure it out at some stage, but if not then I won't be able to run tests.

Unfortunately testling doesn't seem supported on OS X. I will try to figure it out at some stage, but if not then I won't be able to run tests.
darylteo commented 2016-01-04 06:56:41 -05:00 (Migrated from github.com)
Copy Link

Will note that some other test is failing, not my changes.

Will note that some other test is failing, not my changes.
MoOx commented 2016-01-05 01:14:14 -05:00 (Migrated from github.com)
Copy Link

Looks good !

Looks good !
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
iLoveElysia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#49
Delete Branch "patch-39"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?