iLoveElysia/pjax
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

Add timeout for XHR requests #95

Merged
BehindTheMath merged 2 commits from enhancement/add-xhr-timeout into master 2018-01-07 23:56:12 -05:00
Conversation 3 Commits 2 Files Changed 4 +12 -1
BehindTheMath commented 2017-12-21 23:02:52 -05:00 (Migrated from github.com)
Copy Link

Closes #24.

Closes #24.
BehindTheMath commented 2017-12-21 23:03:54 -05:00 (Migrated from github.com)
Copy Link

I thought 600ms (see the title of #24) was a bit short, so I set the default at 10000ms, and gave the user the option of setting it manually.

I thought 600ms (see the title of #24) was a bit short, so I set the default at 10000ms, and gave the user the option of setting it manually.
BehindTheMath commented 2017-12-21 23:31:22 -05:00 (Migrated from github.com)
Copy Link

I changed my mind, and switched the default timeout to 0 (disabled). I think it's better to give the user the ability to opt in to a timeout, instead of forcing it on them by default.

I changed my mind, and switched the default timeout to 0 (disabled). I think it's better to give the user the ability to opt in to a timeout, instead of forcing it on them by default.
MoOx (Migrated from github.com) approved these changes 2018-01-02 04:38:42 -05:00
Sign in to join this conversation.
Reviewers
No Reviewers
MoOx
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
iLoveElysia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#95
Delete Branch "enhancement/add-xhr-timeout"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?