Add default switches to Pjax.switches #92

2017-12-19T00:35:33-05:00

BehindTheMath commented

2017-12-19 00:35:33 -05:00

(Migrated from github.com)

Fixes #68 and reverts #74

BehindTheMath commented

2017-12-19 01:27:54 -05:00

(Migrated from github.com)

#74 fixed #68 in one instance in the README, by changing Pjax.switches.sideBySide to require("pjax/lib/switches.js").sideBySide.
However, there are still 5 other places in the README where the old syntax is still used (Pjax.switches.*).
Additionally, using require precludes users from using Pjax as a simple drop-in script tag, and requires the use of a bundler like Browserify, as mentioned here.

This PR restores the original functionality by attaching the default switches as Pjax.switches.*.

#74 fixed #68 in one instance in the README, by changing `Pjax.switches.sideBySide` to `require("pjax/lib/switches.js").sideBySide`. However, there are still 5 other places in the README where the old syntax is still used (`Pjax.switches.*`). Additionally, using `require` precludes users from using Pjax as a simple drop-in script tag, and requires the use of a bundler like Browserify, as mentioned [here](https://github.com/MoOx/pjax/issues/68#issuecomment-304158707). This PR restores the original functionality by attaching the default switches as `Pjax.switches.*`.

BehindTheMath commented

2017-12-19 01:29:27 -05:00

(Migrated from github.com)

I tried running the tests locally, but I ran into multiple issues.

JSCS wouldn't run with a wildcard path, no matter how I tried setting it. When I ran it with a loop on all files, it found style warnings, but nothing created by this commit.

Testling crashed immediately with no descriptive error message.

However, the Travis build passed.

I tried running the tests locally, but I ran into multiple issues. JSCS wouldn't run with a wildcard path, no matter how I tried setting it. When I ran it with a loop on all files, it found style warnings, but nothing created by this commit. Testling crashed immediately with no descriptive error message. However, the Travis build passed.

MoOx commented

2017-12-19 07:47:12 -05:00

(Migrated from github.com)

Sorry this project is clearly not actively maintained.
JSCS should be remove (and replaced with prettier imo - I love the standard + "no config" approach).
I am also not surprised that there is some errors with tests...

Sorry this project is clearly not actively maintained. JSCS should be remove (and replaced with [prettier](https://github.com/prettier/prettier) imo - I love the standard + "no config" approach). I am also not surprised that there is some errors with tests...

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#92