iLoveElysia/pjax
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

Asynchronous switch functions #79

Merged
oskarrough merged 2 commits from async-onswitch into master 2017-12-19 07:58:23 -05:00
Conversation 3 Commits 2 Files Changed 4
+5 -3
oskarrough commented 2016-11-15 17:10:19 -05:00 (Migrated from github.com)
Copy link
Copy source

Hi, I added this.parseDOM(document) to the onSwitch() callback. This fixes https://github.com/MoOx/pjax/issues/72

Although it works for me, the tests wouldn't run on my machine so if anyone could help test it, I'd appreciate it. Edit: seems Travis helped.

Hi, I added `this.parseDOM(document)` to the `onSwitch()` callback. This fixes https://github.com/MoOx/pjax/issues/72 Although it works for me, the tests wouldn't run on my machine so if anyone could help test it, I'd appreciate it. _Edit: seems Travis helped._
oskarrough commented 2017-01-23 04:35:00 -05:00 (Migrated from github.com)
Copy link
Copy source

ping @MoOx

ping @MoOx
MoOx commented 2017-01-23 04:40:09 -05:00 (Migrated from github.com)
Copy link
Copy source

Is the change in example really necessary?

Is the change in example really necessary?
oskarrough commented 2017-01-23 04:53:48 -05:00 (Migrated from github.com)
Copy link
Copy source

No, thought it clarified the usage a bit. Would you like me to remove it again?

No, thought it clarified the usage a bit. Would you like me to remove it again?
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
invalid
question
wontfix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
iLoveElysia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#79