iLoveElysia/pjax
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

Fixed issue where couldn't set history state to 'false' #76

Closed
tony2nite wants to merge 2 commits from master into master
pull from: master
merge into: iLoveElysia:master
Conversation 2 Commits 2 Files Changed 2 +13877 -12982
tony2nite commented 2016-10-01 12:36:15 -05:00 (Migrated from github.com)
Copy Link

The logic for parsing the history option wouldn't let you set it to false and turn off history

The logic for parsing the history option wouldn't let you set it to false and turn off history
MoOx commented 2016-10-24 22:41:42 -05:00 (Migrated from github.com)
Copy Link

Any reason you closed this?

Any reason you closed this?
tony2nite commented 2016-11-08 06:12:36 -05:00 (Migrated from github.com)
Copy Link

Sorry, two reasons.

One: I badly managed the push and ended up combining the second fix with the first. Would have preferred to address the two issues separately.

Secondly I noticed that to fully implement the state=false fix, this feature test should be change so that it passes OK if pushstate is disabled. Because if we're explicitly disabling pushstate, we don't feature test for it. I think.

Lastly as I couldn't get the test runner working so was hesitant to update untested.

Sorry, two reasons. One: I badly managed the push and ended up combining the second fix with the first. Would have preferred to address the two issues separately. Secondly I noticed that to fully implement the `state=false` fix, this [feature test](https://github.com/MoOx/pjax/blob/master/index.js#L226) should be change so that it passes OK if pushstate is disabled. Because if we're explicitly disabling pushstate, we don't feature test for it. I think. Lastly as I couldn't get the test runner working so was hesitant to update untested.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
iLoveElysia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#76
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?