iLoveElysia/pjax
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

Polyfill XHR.responseURL so tests pass in old Safari #73

Merged
tremby merged 1 commits from add-cachebust-option into master 2016-07-10 23:55:47 -05:00
Conversation 3 Commits 1 Files Changed 1 +12
tremby commented 2016-07-05 03:18:59 -05:00 (Migrated from github.com)
Copy Link

This property is only used in the tests. It doesn't exist in Safari 8 and before, so where it's not available this patch polyfills it, allowing the test to continue.

This property is only used in the tests. It doesn't exist in Safari 8 and before, so where it's not available this patch polyfills it, allowing the test to continue.
tremby commented 2016-07-05 03:20:44 -05:00 (Migrated from github.com)
Copy Link

The pjax functionality was fine, by the way -- it was just the test which failed. The test wanted to check what URL was actually requested by the XHR, but Safari <=8 doesn't have the xhr.responseURL property. That's not used in the application code, just the tests.

The pjax functionality was fine, by the way -- it was just the test which failed. The test wanted to check what URL was actually requested by the XHR, but Safari <=8 doesn't have the `xhr.responseURL` property. That's not used in the application code, just the tests.
tremby commented 2016-07-05 03:22:01 -05:00 (Migrated from github.com)
Copy Link

I'll clarify as well that this polyfill is only loaded during testing, not as part of the pjax library.

I'll clarify as well that this polyfill is only loaded during testing, not as part of the pjax library.
MoOx commented 2016-07-11 00:12:20 -05:00 (Migrated from github.com)
Copy Link

I just cut 0.2.4

I just cut 0.2.4
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
iLoveElysia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#73
Delete Branch "add-cachebust-option"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?