Update refresh and handle attributes without values #67

Merged

compressed merged 2 commits from refresh into master 2016-06-28 00:17:43 -05:00

Conversation 3 Commits 2 Files Changed 2

+7 -5

compressed commented 2016-04-19 11:20:08 -05:00 (Migrated from github.com)

Copy link

Copy source

Hi,
I made two changes here:

1. Implement @robinnorth's suggestion here https://github.com/MoOx/pjax/pull/36 for refresh.
2. Handle attributes without any values (e.g. itemscope was causing an issue).

Let me know any feedback!

Thanks.

Hi, I made two changes here: 1. Implement @robinnorth's suggestion here https://github.com/MoOx/pjax/pull/36 for refresh. 2. Handle attributes without any values (e.g. `itemscope` was causing an issue). Let me know any feedback! Thanks.

👍 1

MoOx commented 2016-06-28 00:18:02 -05:00 (Migrated from github.com)

Copy link

Copy source

No test but I guess it's better than nothing :) Thanks!

No test but I guess it's better than nothing :) Thanks!

MoOx commented 2016-06-28 00:18:20 -05:00 (Migrated from github.com)

Copy link

Copy source

Will cut a release when this is fixed https://github.com/MoOx/pjax/pull/71#issuecomment-228950580

Will cut a release when this is fixed https://github.com/MoOx/pjax/pull/71#issuecomment-228950580

MoOx commented 2016-07-11 00:12:54 -05:00 (Migrated from github.com)

Copy link

Copy source

Released in 0.2.4

Released in 0.2.4

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

dependencies

Pull requests that update a dependency file

duplicate

enhancement

invalid

question

wontfix

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

iLoveElysia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#67