iLoveElysia/pjax
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

fixed an error when using pjax with google analytics #59

Merged
coolhihi merged 1 commits from master into master 2016-03-12 01:09:55 -05:00
Conversation 2 Commits 1 Files Changed 1 +2 -2
coolhihi commented 2016-01-15 04:37:21 -05:00 (Migrated from github.com)
Copy Link

options.analytics() didn't have any param. so ga("send", "pageview", {"page": options.url, "title": options.title}) got an error Cannot read property 'url' of undefined.

I fixed it by replaced with ga("send", "pageview", {"page": location.pathname, "title": document.title}).

`options.analytics()` didn't have any param. so `ga("send", "pageview", {"page": options.url, "title": options.title})` got an error `Cannot read property 'url' of undefined`. I fixed it by replaced with `ga("send", "pageview", {"page": location.pathname, "title": document.title})`.
mikaelengstrom commented 2016-03-07 03:34:31 -05:00 (Migrated from github.com)
Copy Link

@MoOx, Could you merge this and make a release? I have the same issue.

@MoOx, Could you merge this and make a release? I have the same issue.
MoOx commented 2016-03-12 01:09:45 -05:00 (Migrated from github.com)
Copy Link

Better than nothing. Thanks !

Better than nothing. Thanks !
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
iLoveElysia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#59
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?