iLoveElysia/pjax
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

Patch 51 #52

Merged
darylteo merged 4 commits from patch-51 into master 2016-01-05 01:15:11 -05:00
Conversation 7 Commits 4 Files Changed 2 +44 -7
darylteo commented 2016-01-04 23:06:34 -05:00 (Migrated from github.com)
Copy Link

Fixing a bunch of completely breaking errors as listed in #51

Also includes a very basic switch-selectors test.

Fixing a bunch of completely breaking errors as listed in #51 Also includes a very basic switch-selectors test.
MoOx commented 2016-01-05 01:15:05 -05:00 (Migrated from github.com)
Copy Link

Great job. Thanks !

Great job. Thanks !
MoOx commented 2016-01-05 01:18:01 -05:00 (Migrated from github.com)
Copy Link

Not sure if you want a new release now.
Where you using 0.1.4 or 0.2.0 ?
If you plan to make things better, I can add you as a collaborator.

Not sure if you want a new release now. Where you using 0.1.4 or 0.2.0 ? If you plan to make things better, I can add you as a collaborator.
MoOx commented 2016-01-05 01:18:52 -05:00 (Migrated from github.com)
Copy Link

Ping me if you want me to cut a release.

Ping me if you want me to cut a release.
darylteo commented 2016-01-05 01:22:40 -05:00 (Migrated from github.com)
Copy Link

@moOx Please do that will speed things up. But my involvement will extend
up to the point where we decide that pjax will work on our application (I'm
on company time)

I just started using 0.2 branch
On Tue, Jan 5, 2016 at 5:18 PM Maxime Thirouin notifications@github.com
wrote:

Not sure if you want a new release now.
Where you using 0.1.4 or 0.2.0 ?
If you plan to make things better, I can add you as a collaborator.

—
Reply to this email directly or view it on GitHub
https://github.com/MoOx/pjax/pull/52#issuecomment-168913519.

@moOx Please do that will speed things up. But my involvement will extend up to the point where we decide that pjax will work on our application (I'm on company time) I just started using 0.2 branch On Tue, Jan 5, 2016 at 5:18 PM Maxime Thirouin notifications@github.com wrote: > Not sure if you want a new release now. > Where you using 0.1.4 or 0.2.0 ? > If you plan to make things better, I can add you as a collaborator. > > — > Reply to this email directly or view it on GitHub > https://github.com/MoOx/pjax/pull/52#issuecomment-168913519.
MoOx commented 2016-01-05 01:29:55 -05:00 (Migrated from github.com)
Copy Link

@darylteo I added you as a collab. Here is what I ask for now:

  • use PR all the times
  • your PR should includes CHANGELOG notes if you fix a bug (Fixed: ...) or add a feature (Added:...) or change something (Changed: ..)

Are you familiar with semver?

@darylteo I added you as a collab. Here is what I ask for now: - use PR all the times - your PR should includes CHANGELOG notes if you fix a bug (Fixed: ...) or add a feature (Added:...) or change something (Changed: ..) Are you familiar with semver?
darylteo commented 2016-01-05 01:32:36 -05:00 (Migrated from github.com)
Copy Link

Familiar enough I hope.

Do you prefer large PRs or small feature PRs like what I just done?

On Tue, Jan 5, 2016 at 5:29 PM Maxime Thirouin notifications@github.com
wrote:

@darylteo https://github.com/darylteo I added you as a collab. Here is
what I ask for now:

  • use PR all the times
  • your PR should includes CHANGELOG notes if you fix a bug (Fixed:
    ...) or add a feature (Added:...) or change something (Changed: ..)

Are you familiar with semver?

—
Reply to this email directly or view it on GitHub
https://github.com/MoOx/pjax/pull/52#issuecomment-168915624.

Familiar enough I hope. Do you prefer large PRs or small feature PRs like what I just done? On Tue, Jan 5, 2016 at 5:29 PM Maxime Thirouin notifications@github.com wrote: > @darylteo https://github.com/darylteo I added you as a collab. Here is > what I ask for now: > - use PR all the times > - your PR should includes CHANGELOG notes if you fix a bug (Fixed: > ...) or add a feature (Added:...) or change something (Changed: ..) > > Are you familiar with semver? > > — > Reply to this email directly or view it on GitHub > https://github.com/MoOx/pjax/pull/52#issuecomment-168915624.
MoOx commented 2016-01-05 01:40:19 -05:00 (Migrated from github.com)
Copy Link

What you did is perfect and easier to review. I just pushed some updates to the CHANGELOG.
Feel free to link issue (and not PR) in the CHANGELOG when you commit something. And btw, one commit for fix + test is fine.

What you did is perfect and easier to review. I just pushed some updates to the CHANGELOG. Feel free to link issue (and not PR) in the CHANGELOG when you commit something. And btw, one commit for fix + test is fine.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
iLoveElysia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#52
Delete Branch "patch-51"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?