iLoveElysia/pjax
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

Switch linting to ESLint and Prettier #191

Merged
BehindTheMath merged 4 commits from feature/eslint-and-prettier into master 2019-02-13 22:26:57 -05:00
Conversation 6 Commits 4 Files Changed 23 +2 -4
3 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 8386b355c9 - Show all commits

1
.eslintignore
View File

@@ -1,4 +1,3 @@
MoOx commented 2019-01-02 12:13:28 -05:00 (Migrated from github.com)
Review
Copy Link

No need for this. In
https://eslint.org/docs/user-guide/configuring#eslintignore
you can read

/node_modules/* and /bower_components/* in the project root are ignored by default

I think it's the same for prettier.

Something I do sometimes is to symlink this *ignore to .gitignore (eg: that's what I do here https://github.com/MoOx/eslint-config-i-am-meticulous)

No need for this. In https://eslint.org/docs/user-guide/configuring#eslintignore you can read > # /node_modules/* and /bower_components/* in the project root are ignored by default I think it's the same for prettier. Something I do sometimes is to symlink this *ignore to .gitignore (eg: that's what I do here https://github.com/MoOx/eslint-config-i-am-meticulous)
MoOx commented 2019-01-02 12:13:28 -05:00 (Migrated from github.com)
Review
Copy Link

No need for this. In
https://eslint.org/docs/user-guide/configuring#eslintignore
you can read

/node_modules/* and /bower_components/* in the project root are ignored by default

I think it's the same for prettier.

Something I do sometimes is to symlink this *ignore to .gitignore (eg: that's what I do here https://github.com/MoOx/eslint-config-i-am-meticulous)

No need for this. In https://eslint.org/docs/user-guide/configuring#eslintignore you can read > # /node_modules/* and /bower_components/* in the project root are ignored by default I think it's the same for prettier. Something I do sometimes is to symlink this *ignore to .gitignore (eg: that's what I do here https://github.com/MoOx/eslint-config-i-am-meticulous)
pjax.js
node_modules/**
MoOx commented 2019-01-02 12:13:28 -05:00 (Migrated from github.com)
Review
Copy Link

No need for this. In
https://eslint.org/docs/user-guide/configuring#eslintignore
you can read

/node_modules/* and /bower_components/* in the project root are ignored by default

I think it's the same for prettier.

Something I do sometimes is to symlink this *ignore to .gitignore (eg: that's what I do here https://github.com/MoOx/eslint-config-i-am-meticulous)

No need for this. In https://eslint.org/docs/user-guide/configuring#eslintignore you can read > # /node_modules/* and /bower_components/* in the project root are ignored by default I think it's the same for prettier. Something I do sometimes is to symlink this *ignore to .gitignore (eg: that's what I do here https://github.com/MoOx/eslint-config-i-am-meticulous)
pjax.min.js
*.json
MoOx commented 2019-01-02 12:13:28 -05:00 (Migrated from github.com)
Review
Copy Link

No need for this. In
https://eslint.org/docs/user-guide/configuring#eslintignore
you can read

/node_modules/* and /bower_components/* in the project root are ignored by default

I think it's the same for prettier.

Something I do sometimes is to symlink this *ignore to .gitignore (eg: that's what I do here https://github.com/MoOx/eslint-config-i-am-meticulous)

No need for this. In https://eslint.org/docs/user-guide/configuring#eslintignore you can read > # /node_modules/* and /bower_components/* in the project root are ignored by default I think it's the same for prettier. Something I do sometimes is to symlink this *ignore to .gitignore (eg: that's what I do here https://github.com/MoOx/eslint-config-i-am-meticulous)
MoOx commented 2019-01-02 12:13:28 -05:00 (Migrated from github.com)
Review
Copy Link

No need for this. In
https://eslint.org/docs/user-guide/configuring#eslintignore
you can read

/node_modules/* and /bower_components/* in the project root are ignored by default

I think it's the same for prettier.

Something I do sometimes is to symlink this *ignore to .gitignore (eg: that's what I do here https://github.com/MoOx/eslint-config-i-am-meticulous)

No need for this. In https://eslint.org/docs/user-guide/configuring#eslintignore you can read > # /node_modules/* and /bower_components/* in the project root are ignored by default I think it's the same for prettier. Something I do sometimes is to symlink this *ignore to .gitignore (eg: that's what I do here https://github.com/MoOx/eslint-config-i-am-meticulous)

1
.prettierignore
View File

@@ -1,4 +1,3 @@
pjax.js
node_modules/**
pjax.min.js
*.json

4
package.json
View File

@@ -45,7 +45,7 @@
"uglify-js": "^3.3.8"
},
"scripts": {
"lint": "eslint **/*.js",
"lint": "eslint .",
"standalone": "browserify index.js --standalone Pjax > pjax.js",
"build": "npm run standalone && uglifyjs pjax.js -o pjax.min.js",
"build-debug": "browserify index.js --debug --standalone Pjax > pjax.js",
@@ -64,7 +64,7 @@
},
"lint-staged": {
"*.js": [
"eslint --fix **/*.js",
"eslint --fix",
"prettier --write",
"git add"
]