Switch linting to ESLint and Prettier #191

2018-12-23T11:42:39-05:00

BehindTheMath commented

2018-12-23 11:42:39 -05:00

(Migrated from github.com)

Close #97.

robinnorth (Migrated from github.com) reviewed 2018-12-23 11:42:39 -05:00

BehindTheMath commented

2018-12-23 13:31:57 -05:00

(Migrated from github.com)

I'm not sure why Travis is failing now. .eslintignore excludes node_modules/**.

I'm not sure why Travis is failing now. [`.eslintignore`](https://github.com/MoOx/pjax/blob/79295232e7b82879b96edeb9f12d67f7c7031e1f/.eslintignore) excludes `node_modules/**`.

MoOx (Migrated from github.com) reviewed 2019-01-02 12:13:37 -05:00

.eslintignore

MoOx (Migrated from github.com) commented

2019-01-02 12:13:28 -05:00

No need for this. In
https://eslint.org/docs/user-guide/configuring#eslintignore
you can read

/node_modules/* and /bower_components/* in the project root are ignored by default

I think it's the same for prettier.

Something I do sometimes is to symlink this *ignore to .gitignore (eg: that's what I do here https://github.com/MoOx/eslint-config-i-am-meticulous)

No need for this. In https://eslint.org/docs/user-guide/configuring#eslintignore you can read > # /node_modules/* and /bower_components/* in the project root are ignored by default I think it's the same for prettier. Something I do sometimes is to symlink this *ignore to .gitignore (eg: that's what I do here https://github.com/MoOx/eslint-config-i-am-meticulous)

package.json

MoOx (Migrated from github.com) commented

2019-01-02 12:08:45 -05:00

I think you can just do "eslint ."

I think you can just do `"eslint ."`

package.json

MoOx (Migrated from github.com) commented

2019-01-02 12:09:34 -05:00

File will be passed as argument, so you don't need to send **/*.js. Just `"eslint --fix",

File will be passed as argument, so you don't need to send `**/*.js`. Just `"eslint --fix",

BehindTheMath commented

2019-02-12 22:03:54 -05:00

(Migrated from github.com)

@MoOx How about now?

MoOx (Migrated from github.com) approved these changes 2019-02-13 07:52:37 -05:00

MoOx commented

2019-02-13 07:53:01 -05:00

(Migrated from github.com)

Looks good!

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#191