iLoveElysia/pjax
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

0.2.6 #155

Merged
BehindTheMath merged 1 commits from v0.2.6 into master 2018-04-30 14:10:26 -05:00
Conversation 5 Commits 1 Files Changed 2
+24 -1
BehindTheMath commented 2018-04-30 08:56:22 -05:00 (Migrated from github.com)
Copy link
Copy source

These are all bug fixes, so I think 0.2.6 is best for now.

I would like to make the next version 0.3.0 so we can implement some of the breaking changes we discussed. If that goes smoothly, I think we can release 1.0.0.

These are all bug fixes, so I think 0.2.6 is best for now. I would like to make the next version 0.3.0 so we can implement some of the breaking changes we discussed. If that goes smoothly, I think we can release 1.0.0.
robinnorth (Migrated from github.com) approved these changes 2018-04-30 09:05:11 -05:00
robinnorth (Migrated from github.com) left a comment
Copy link
Copy source

LGTM 🎉

LGTM 🎉
robinnorth commented 2018-04-30 09:09:59 -05:00 (Migrated from github.com)
Copy link
Copy source

@BehindTheMath We could just make the next milestone 1.0.0, as things like making Pjax an event emitter will be breaking API changes that should trigger a major version bump, according to SemVer. (Technically, as we've added a few new features that are backwards-compatible in this release, SemVer would dictate that this release be 0.3.0.)

@BehindTheMath We could just make the next milestone 1.0.0, as things like making Pjax an event emitter will be breaking API changes that should trigger a major version bump, according to SemVer. (Technically, as we've added a few new features that are backwards-compatible in this release, SemVer would dictate that _this_ release be 0.3.0.)
BehindTheMath commented 2018-04-30 09:12:20 -05:00 (Migrated from github.com)
Copy link
Copy source

If I'm not mistaken, for versions lower than v1.0.0, everything jumps 1 position to the right. So patches and backwards-compatible changes bump the patch number, and breaking changes bump the minor version number, since you don't want to go above 1.0.0 yet.

If I'm not mistaken, for versions lower than v1.0.0, everything jumps 1 position to the right. So patches and backwards-compatible changes bump the patch number, and breaking changes bump the minor version number, since you don't want to go above 1.0.0 yet.
robinnorth commented 2018-04-30 09:19:20 -05:00 (Migrated from github.com)
Copy link
Copy source

Ah yes, you are right -- major version 0 is considered to be development, so the public API rules that dictate bumping don't apply yet. Let's go with your plan then!

Ah yes, you are right -- major version 0 is considered to be development, so the public API rules that dictate bumping don't apply yet. Let's go with your plan then!
BehindTheMath commented 2018-04-30 14:51:08 -05:00 (Migrated from github.com)
Copy link
Copy source

v0.2.6 has been pushed to npm.

v0.2.6 has been pushed to npm.
🎉 1
Sign in to join this conversation.
Reviewers
No Reviewers
robinnorth
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
invalid
question
wontfix
No labels
Milestone
No items
No Milestone 0.2.6
Projects
Clear projects
No projects
Assignees
Clear assignees
iLoveElysia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#155