iLoveElysia/pjax
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

0.2.5 #121

Merged
BehindTheMath merged 2 commits from update/v0.2.5 into master 2018-02-02 11:12:28 -05:00
Conversation 7 Commits 2 Files Changed 2
+37 -1
BehindTheMath commented 2018-02-02 10:00:41 -05:00 (Migrated from github.com)
Copy link
Copy source
No description provided.
MoOx (Migrated from github.com) approved these changes 2018-02-02 10:37:08 -05:00
MoOx (Migrated from github.com) left a comment
Copy link
Copy source

Nice work guys!

That said, I think you should cut a 1.0.0 and use semver more seriously than I did in the past :)

Nice work guys! That said, I think you should cut a 1.0.0 and use semver more seriously than I did in the past :)
BehindTheMath commented 2018-02-02 10:44:41 -05:00 (Migrated from github.com)
Copy link
Copy source

Nice work guys!

Thank you!

That said, I think you should cut a 1.0.0 and use semver more seriously than I did in the past :)

All the commits we made since 0.2.4 were really bug fixes and code cleanup, so I thought it would be better to wait to bump to 1.0.0 so that the update would go out to anyone currently using 0.2.4.

>Nice work guys! Thank you! >That said, I think you should cut a 1.0.0 and use semver more seriously than I did in the past :) All the commits we made since 0.2.4 were really bug fixes and code cleanup, so I thought it would be better to wait to bump to 1.0.0 so that the update would go out to anyone currently using 0.2.4.
robinnorth commented 2018-02-02 11:09:10 -05:00 (Migrated from github.com)
Copy link
Copy source

Thanks @MoOx! It certainly feels like it could be a 1.0.0 with the amount of changes made and effort put in, and I'm all for using SemVer religiously from now on, but @BehindTheMath does make a good point about 0.2.4 users getting the update automatically.

That being said, 1.0.0 is a nice symbolic bump and 0.2.4 users can manually upgrade if there's a particular fix they've been waiting for...

Thanks @MoOx! It certainly feels like it could be a 1.0.0 with the amount of changes made and effort put in, and I'm all for using SemVer religiously from now on, but @BehindTheMath does make a good point about 0.2.4 users getting the update automatically. That being said, 1.0.0 is a nice symbolic bump and 0.2.4 users can manually upgrade if there's a particular fix they've been waiting for...
robinnorth (Migrated from github.com) reviewed 2018-02-02 11:10:10 -05:00
robinnorth (Migrated from github.com) left a comment
Copy link
Copy source

I've added a couple of extra changes to the log, based on PRs made between now and 0.2.4, but otherwise I think we're all good to go!

I've added a couple of extra changes to the log, based on PRs made between now and 0.2.4, but otherwise I think we're all good to go!
robinnorth (Migrated from github.com) approved these changes 2018-02-02 11:10:25 -05:00
BehindTheMath commented 2018-02-02 11:46:55 -05:00 (Migrated from github.com)
Copy link
Copy source

Version 0.2.5 has been released to NPM.

Version 0.2.5 has been released to NPM.
🎉 1
robinnorth commented 2018-02-02 12:31:46 -05:00 (Migrated from github.com)
Copy link
Copy source

Fantastic, nice work all! 🎉

Fantastic, nice work all! 🎉
Sign in to join this conversation.
Reviewers
No Reviewers
MoOx
robinnorth
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
invalid
question
wontfix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
iLoveElysia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#121