iLoveElysia/pjax
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

Fix external scripts events #118

Merged
robinnorth merged 2 commits from fix/external-scripts-events into master 2018-01-31 16:46:29 -05:00
Conversation 4 Commits 2 Files Changed 2
+6 -8
robinnorth commented 2018-01-26 10:58:51 -05:00 (Migrated from github.com)
Copy link
Copy source

Fixes #117

Fixes #117
robinnorth commented 2018-01-30 05:27:04 -05:00 (Migrated from github.com)
Copy link
Copy source

@BehindTheMath are we good to merge this, or are you still awaiting input from @joshkadis / @lacrioque on #35?

@BehindTheMath are we good to merge this, or are you still awaiting input from @joshkadis / @lacrioque on #35?
BehindTheMath commented 2018-01-30 09:30:54 -05:00 (Migrated from github.com)
Copy link
Copy source

I think we should wait a bit longer to see if they have any input.

I think we should wait a bit longer to see if they have any input.
👍 1
BehindTheMath commented 2018-01-31 16:46:05 -05:00 (Migrated from github.com)
Copy link
Copy source

At this point, I think we should merge this and close #35. If there's any issues later, we can always reopen it.

At this point, I think we should merge this and close #35. If there's any issues later, we can always reopen it.
👍 1
BehindTheMath (Migrated from github.com) approved these changes 2018-01-31 16:46:16 -05:00
Sign in to join this conversation.
Reviewers
No Reviewers
BehindTheMath
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
invalid
question
wontfix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
iLoveElysia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#118