iLoveElysia/pjax
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

Replace instances of ES6 const keyword with var #107

Merged
robinnorth merged 1 commits from replace-es6-syntax into master 2018-01-18 16:00:25 -05:00
Conversation 4 Commits 1 Files Changed 3 +3 -3
robinnorth commented 2018-01-18 15:49:35 -05:00 (Migrated from github.com)
Copy Link

Fixes #106

Fixes #106
BehindTheMath commented 2018-01-18 16:00:32 -05:00 (Migrated from github.com)
Copy Link

Thanks.

Thanks.
MoOx commented 2018-01-19 01:02:25 -05:00 (Migrated from github.com)
Copy Link

IMO we should keep es6 syntax and use babel to transpile for old browser when creating a bundle.

IMO we should keep es6 syntax and use babel to transpile for old browser when creating a bundle.
BehindTheMath commented 2018-01-19 01:08:11 -05:00 (Migrated from github.com)
Copy Link

We can do that, but it will mean a major revamp of the code, which will include removing a bunch of legacy code, like the polyfills for Function.prototype.bind, and Array.prototype.forEach.

I think that should wait until we finish fixing all the existing issues, so we don't cause any conflicts. I'll open a new issue to track that.

We can do that, but it will mean a major revamp of the code, which will include removing a bunch of legacy code, like the polyfills for `Function.prototype.bind`, and `Array.prototype.forEach`. I think that should wait until we finish fixing all the existing issues, so we don't cause any conflicts. I'll open a new issue to track that.
MoOx commented 2018-01-19 01:16:33 -05:00 (Migrated from github.com)
Copy Link

Make sense

Make sense
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
iLoveElysia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#107
Delete Branch "replace-es6-syntax"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?