Replace instances of ES6 const keyword with var #107

2018-01-18T15:49:35-05:00

robinnorth commented

2018-01-18 15:49:35 -05:00

(Migrated from github.com)

Fixes #106

BehindTheMath commented

2018-01-18 16:00:32 -05:00

(Migrated from github.com)

Thanks.

MoOx commented

2018-01-19 01:02:25 -05:00

(Migrated from github.com)

IMO we should keep es6 syntax and use babel to transpile for old browser when creating a bundle.

BehindTheMath commented

2018-01-19 01:08:11 -05:00

(Migrated from github.com)

We can do that, but it will mean a major revamp of the code, which will include removing a bunch of legacy code, like the polyfills for Function.prototype.bind, and Array.prototype.forEach.

I think that should wait until we finish fixing all the existing issues, so we don't cause any conflicts. I'll open a new issue to track that.

We can do that, but it will mean a major revamp of the code, which will include removing a bunch of legacy code, like the polyfills for `Function.prototype.bind`, and `Array.prototype.forEach`. I think that should wait until we finish fixing all the existing issues, so we don't cause any conflicts. I'll open a new issue to track that.

MoOx commented

2018-01-19 01:16:33 -05:00

(Migrated from github.com)

Make sense

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#107

Replace instances of ES6 const keyword with var #107

Replace instances of ES6 `const` keyword with `var` #107