fixed an error when using pjax with google analytics #59

2016-01-15T04:37:21-05:00

coolhihi commented

2016-01-15 04:37:21 -05:00

(Migrated from github.com)

options.analytics() didn't have any param. so ga("send", "pageview", {"page": options.url, "title": options.title}) got an error Cannot read property 'url' of undefined.

I fixed it by replaced with ga("send", "pageview", {"page": location.pathname, "title": document.title}).

`options.analytics()` didn't have any param. so `ga("send", "pageview", {"page": options.url, "title": options.title})` got an error `Cannot read property 'url' of undefined`. I fixed it by replaced with `ga("send", "pageview", {"page": location.pathname, "title": document.title})`.

mikaelengstrom commented

2016-03-07 03:34:31 -05:00

(Migrated from github.com)

@MoOx, Could you merge this and make a release? I have the same issue.

MoOx commented

2016-03-12 01:09:45 -05:00

(Migrated from github.com)

Better than nothing. Thanks !

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#59