iLoveElysia/pjax
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

Fix Edge form support #178

Merged
robinnorth merged 2 commits from fix/edge-form-support into master 2018-10-10 12:21:05 -05:00
Conversation 1 Commits 2 Files Changed 2 +8 -11
robinnorth commented 2018-10-10 08:29:21 -05:00 (Migrated from github.com)
Copy Link

Using a for... in loop to iterate a HTMLElementCollection as we did in proto/attach-form.js is evidently not a very good idea as our implementation doesn't work in Microsoft Edge, so I have swapped it out for a for loop that does work across all the browsers that we support.

Fixes #177

Using a `for... in` loop to iterate a `HTMLElementCollection` as we did in `proto/attach-form.js` is evidently not a very good idea as our implementation doesn't work in Microsoft Edge, so I have swapped it out for a `for` loop that does work across all the browsers that we support. Fixes #177
BehindTheMath (Migrated from github.com) approved these changes 2018-10-10 12:20:38 -05:00
Sign in to join this conversation.
Reviewers
No Reviewers
BehindTheMath
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
iLoveElysia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#178
Delete Branch "fix/edge-form-support"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?