Form Params Not Sending on Microsoft Edge #177

New Issue

2018-10-06T10:29:55-05:00

chaiim commented

2018-10-06 10:29:55 -05:00

(Migrated from github.com)

Form parameters don't seem to be sending when using Microsoft Edge. The form submits using pjax still, but the parameters array sent is empty.

Seems to be an issue with the function parseFormElements, it never gets past this line,
if (!!element.name && element.attributes !== undefined && tagName !== "button")

to actually fill in the parameters.

Form parameters don't seem to be sending when using Microsoft Edge. The form submits using pjax still, but the parameters array sent is empty. Seems to be an issue with the function parseFormElements, it never gets past this line, if (!!element.name && element.attributes !== undefined && tagName !== "button") to actually fill in the parameters.

chaiim commented

2018-10-06 18:25:35 -05:00

(Migrated from github.com)

Was able to correct this issue manually by updating the parseFormElements function.

I updated

if (Number.isNaN(Number(elementKey))) {
	continue;
}

for

if (!el.elements.hasOwnProperty(elementKey)) {
	continue;
}

Was able to correct this issue manually by updating the **parseFormElements** function. I updated ``` if (Number.isNaN(Number(elementKey))) { continue; } ``` for ``` if (!el.elements.hasOwnProperty(elementKey)) { continue; } ```

robinnorth commented

2018-10-10 08:21:42 -05:00

(Migrated from github.com)

Thanks for the bug report, @chaiim. I have a fix in progress.

chaiim commented

2018-10-10 13:34:03 -05:00

(Migrated from github.com)

Thanks for the fix. That was quick!

BehindTheMath commented

2018-10-10 13:37:38 -05:00

(Migrated from github.com)

It will probably still be a while until a new version is published to npm. If you can't wait, you can clone master and build it yourself in the meantime.

chaiim commented

2018-10-10 16:34:32 -05:00

(Migrated from github.com)

Ah thanks for the heads up. I already have a fixed copy locally just switching to the hasOwnProperty check in the for in. So will just keep that for now until it's the update is pushed live.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#177