Files
BadNote/lib/services/undo_manager.dart
Akiba So 72428dc075
Some checks failed
CI / Test (Server, optional) (push) Failing after 2m10s
Windows Build / Build Windows (x64) (push) Failing after 29s
CI / Test (Flutter, Linux) (push) Has been cancelled
CI / Analyze (Flutter) (push) Has been cancelled
Fix bugs across app + server, optimize UI/UX, add Gitea CI
Bug fixes (Flutter):
- Wrap multi-statement DB writes (insert/update/delete note, deleteDocument,
  deletePageData, OCR FTS merge, migrations) in transactions to prevent data
  loss on interruption and a read-modify-write FTS race.
- Fix PdfDocument leaks on exception (try/finally dispose) and preserve image
  aspect ratio when stamping images onto PDF pages.
- Guard file-picker against empty selection (was .single -> crash).
- Fix eraser ConcurrentModificationError and unmodifiable-list crash on PDF
  pages; capture page synchronously on save to stop wrong-page data loss.
- Fix Riverpod DB-not-ready races, broken pull-to-refresh, settings load race,
  and search N+1; transform stored annotations on PDF page rotation.
- Normalize pen pressure for devices without a pressure range.
- PPT: single source of truth for slide strokes so ink displays and exports.

UI/UX:
- Material 3 typography, theme-aware colors (dark-mode fixes), hover cursors
  and right-click/visible actions on desktop, keyboard shortcuts (undo/redo/
  save/find), toolbar overflow handling, friendlier empty states, semantic OCR
  status badges, relative timestamps, 1-based page indicators, large-deck PPT
  navigation, and a scratchpad-scope label in split view.

Server (optional backend):
- Persist JWT secret (was per-process random), block path traversal in storage,
  fix CORS '*'+credentials, add OCR job ownership checks, last-writer-wins sync
  guard, constant-time login, and split out heavy OCR deps so the API/tests run
  without them.

CI: Gitea workflows for format+analyze+test (Linux, system sqlite) and a
Windows release build; pristine `flutter analyze`, all Flutter and server tests
green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 03:18:00 +08:00

103 lines
3.0 KiB
Dart

import '../models/ink_stroke.dart';
/// Manages undo/redo state for ink strokes.
///
/// Each action records a stroke that was added or removed.
/// [undo] returns the inverse of the last action (remove if add, add if remove).
/// [redo] re-applies the undone action.
class UndoManager {
final List<_UndoAction> _undoStack = [];
final List<_UndoAction> _redoStack = [];
final List<InkStroke> _strokes = [];
/// The current list of strokes (read-only view).
List<InkStroke> get currentStrokes => List.unmodifiable(_strokes);
bool get canUndo => _undoStack.isNotEmpty;
bool get canRedo => _redoStack.isNotEmpty;
/// Records that a new stroke was added to the canvas.
void addStroke(InkStroke stroke) {
_strokes.add(stroke);
_undoStack.add(_UndoAction(type: _ActionType.add, stroke: stroke));
_redoStack.clear();
}
/// Records that a stroke was removed from the canvas.
/// Also handles partial-eraser replacements: removes [stroke] and adds
/// [replacements] (which may be empty if fully erased, or 1-2 sub-strokes).
void removeStroke(
InkStroke stroke, {
List<InkStroke> replacements = const [],
}) {
_strokes.removeWhere((s) => s.id == stroke.id);
_strokes.addAll(replacements);
_undoStack.add(
_UndoAction(
type: _ActionType.remove,
stroke: stroke,
replacements: replacements,
),
);
_redoStack.clear();
}
/// Undoes the last action. Returns the stroke that was affected and needs
/// to be reversed on the canvas, or `null` if nothing to undo.
///
/// For add actions: the stroke should be removed from the canvas.
/// For remove actions: the stroke (and its replacements) should be restored.
InkStroke? undo() {
if (_undoStack.isEmpty) return null;
final action = _undoStack.removeLast();
_redoStack.add(action);
switch (action.type) {
case _ActionType.add:
_strokes.removeWhere((s) => s.id == action.stroke.id);
return action.stroke;
case _ActionType.remove:
// Remove the replacements that were added during the original remove
for (final r in action.replacements) {
_strokes.removeWhere((s) => s.id == r.id);
}
_strokes.add(action.stroke);
return action.stroke;
}
}
/// Redoes the last undone action. Returns the stroke that was affected, or
/// `null` if nothing to redo.
InkStroke? redo() {
if (_redoStack.isEmpty) return null;
final action = _redoStack.removeLast();
_undoStack.add(action);
switch (action.type) {
case _ActionType.add:
_strokes.add(action.stroke);
return action.stroke;
case _ActionType.remove:
_strokes.removeWhere((s) => s.id == action.stroke.id);
_strokes.addAll(action.replacements);
return action.stroke;
}
}
}
enum _ActionType { add, remove }
class _UndoAction {
final _ActionType type;
final InkStroke stroke;
final List<InkStroke> replacements;
_UndoAction({
required this.type,
required this.stroke,
this.replacements = const [],
});
}