iLoveElysia/pjax
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

Add switchElementsAlt() to the default switches #93

Merged
BehindTheMath merged 1 commits from bugfix/add-switchElementsAlt into master 2017-12-20 15:58:30 -05:00
Conversation 5 Commits 1 Files Changed 2
+18 -2
BehindTheMath commented 2017-12-19 15:42:34 -05:00 (Migrated from github.com)
Copy link
Copy source

Fixes #83.

Fixes #83.
BehindTheMath commented 2017-12-19 16:38:58 -05:00 (Migrated from github.com)
Copy link
Copy source

@MoOx I can't figure out why testling is erroring. This PR shouldn't affect that.

The affected tests are here.

@MoOx I can't figure out why testling is erroring. This PR shouldn't affect that. The affected tests are [here](https://github.com/MoOx/pjax/blob/a7b584c469d412ae7333a795a0ac8d3616a96a1f/tests/lib/request.js).
MoOx (Migrated from github.com) approved these changes 2017-12-20 03:14:05 -05:00
MoOx commented 2017-12-20 03:14:38 -05:00 (Migrated from github.com)
Copy link
Copy source

@BehindTheMath since you have been added as a collaborator to this repo, you don't need to use your fork anymore and can cut a branch directly from this repo!

@BehindTheMath since you have been added as a collaborator to this repo, you don't need to use your fork anymore and can cut a branch directly from this repo!
👍 1
MoOx commented 2017-12-20 03:15:35 -05:00 (Migrated from github.com)
Copy link
Copy source

It seems that CI found a regression. Note that testling should be used directly (see note in package.json) if you want to run existing tests

It seems that CI found a regression. Note that testling should be used directly (see note in package.json) if you want to run existing tests
BehindTheMath commented 2017-12-20 15:57:31 -05:00 (Migrated from github.com)
Copy link
Copy source

From the Travis logs, it looks like the regression was caused by #80. However, I don't see anything in that PR either that would cause this error.

Additionally, I ran testling locally in a VM, and it passed with no errors.

So I'm going to take the output of testling with a grain of salt, until it can be switched for an updated testing framework.

From the Travis logs, it looks like the regression was caused by #80. However, I don't see anything in that PR either that would cause this error. Additionally, I ran testling locally in a VM, and it passed with no errors. So I'm going to take the output of testling with a grain of salt, until it can be switched for an updated testing framework.
Sign in to join this conversation.
Reviewers
No Reviewers
MoOx
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
invalid
question
wontfix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
iLoveElysia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#93