iLoveElysia/pjax
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

Replace testling (this project is dead) #63

New Issue
Closed
opened 2016-03-12 01:01:33 -05:00 by MoOx · 6 comments
MoOx commented 2016-03-12 01:01:33 -05:00 (Migrated from github.com)
Copy Link

I have 2 HDD and cannot start testling due to a really stupid bug (I opened an issue several months/years ago)

https://github.com/substack/testling/issues/111

I have 2 HDD and cannot start testling due to a really stupid bug (I opened an issue several months/years ago) https://github.com/substack/testling/issues/111
MoOx commented 2016-03-12 01:06:06 -05:00 (Migrated from github.com)
Copy Link

FYI https://github.com/substack/browser-launcher/pull/26

FYI https://github.com/substack/browser-launcher/pull/26
BehindTheMath commented 2018-01-07 23:50:03 -05:00 (Migrated from github.com)
Copy Link

I've been doing research on options for testing.

It seems that since pjax doesn't do any rendering, most of the goals of testing could be achieved by just using jsdom. This won't indicate any browser-specific quirks, but I think as of now, those should be ironed out, and testing is really to prevent regressions.

I've gotten all the tests to pass using jsdom, with a few small fixes to account for the differences between it and a real browser.

@MoOx what's your opinion?

I've been doing research on options for testing. It seems that since pjax doesn't do any rendering, most of the goals of testing could be achieved by just using [jsdom](https://github.com/tmpvar/jsdom). This won't indicate any browser-specific quirks, but I think as of now, those should be ironed out, and testing is really to prevent regressions. I've gotten all the tests to pass using jsdom, with a few small fixes to account for the differences between it and a real browser. @MoOx what's your opinion?
BehindTheMath commented 2018-01-08 00:06:02 -05:00 (Migrated from github.com)
Copy Link

One thing that will have to changed regardless, is the REST API used for testing XHR requests. The Github API refuses requests with custom headers, due to CORS.

I've tested using httpbin instead, and that seems to be working as expected.

One thing that will have to changed regardless, is the REST API used for testing XHR requests. The Github API refuses requests with custom headers, due to CORS. I've tested using [httpbin](https://httpbin.org) instead, and that seems to be working as expected.
MoOx commented 2018-01-08 05:07:15 -05:00 (Migrated from github.com)
Copy Link

jsdom is ok for me!

jsdom is ok for me!
👍 1
BehindTheMath commented 2018-01-08 16:22:22 -05:00 (Migrated from github.com)
Copy Link

On the subject of testing, It looks like the Travis config needs to be updated. It's running Node 0.10 and NPM 2, which are way out of date. I don't know where that's coming from, since those aren't specified in .travis.yml

On the subject of testing, It looks like the Travis config needs to be updated. It's running Node 0.10 and NPM 2, which are way out of date. I don't know where that's coming from, since those aren't specified in [.travis.yml](https://github.com/MoOx/pjax/blob/6491e3243787556664dc254dcc55b6af226b6786/.travis.yml)
MoOx commented 2018-01-08 16:25:25 -05:00 (Migrated from github.com)
Copy Link

it's default travis version :/

it's default travis version :/
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
invalid
question
wontfix
No Label enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
iLoveElysia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#63
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?