Fix evalScripts() #186

Merged

BehindTheMath merged 2 commits from fix/eval-script into master 2018-11-25 15:21:08 -05:00

Conversation 1 Commits 2 Files Changed 2

+20 -1

BehindTheMath commented 2018-11-21 21:34:34 -05:00 (Migrated from github.com)

Copy link

Copy source

• Set the id of the insert <script>.
• Check if the <script> still exists before trying to remove it.

Fixes #185.

* Set the id of the insert <script>. * Check if the <script> still exists before trying to remove it. Fixes #185.

robinnorth (Migrated from github.com) approved these changes 2018-11-23 08:54:23 -05:00

robinnorth (Migrated from github.com) left a comment

Copy link

Copy source

This all looks good to me 👍

This all looks good to me 👍

Sign in to join this conversation.

Reviewers

No Reviewers

robinnorth

Labels

Clear labels

bug

dependencies

Pull requests that update a dependency file

duplicate

enhancement

invalid

question

wontfix

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

iLoveElysia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#186