iLoveElysia/pjax
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

History option does not work #164

New Issue
Closed
opened 2018-06-08 05:23:36 -05:00 by arjunattam · 0 comments
arjunattam commented 2018-06-08 05:23:36 -05:00 (Migrated from github.com)
Copy Link

If I got it right, setting the history as false will never work because of how the options are parsed.

options.history = options.history || true

This will always return the value as true. I understand there aren't many use-cases for this -- but I was facing this for my browser extension.

Happy to send in a PR if this needs to be fixed.

If I got it right, setting the `history` as `false` will never work because of how the options are parsed. ``` options.history = options.history || true ``` This will always return the value as true. I understand there aren't many use-cases for this -- but I was facing this for my browser extension. Happy to send in a PR if this needs to be fixed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
invalid
question
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
iLoveElysia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#164
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?