History option does not work #164

New Issue

2018-06-08T05:23:36-05:00

arjunattam commented

2018-06-08 05:23:36 -05:00

(Migrated from github.com)

If I got it right, setting the history as false will never work because of how the options are parsed.

options.history = options.history || true

This will always return the value as true. I understand there aren't many use-cases for this -- but I was facing this for my browser extension.

Happy to send in a PR if this needs to be fixed.

If I got it right, setting the `history` as `false` will never work because of how the options are parsed. ``` options.history = options.history || true ``` This will always return the value as true. I understand there aren't many use-cases for this -- but I was facing this for my browser extension. Happy to send in a PR if this needs to be fixed.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#164