iLoveElysia/pjax
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

Fix parsing values of option elements in forms #162

Merged
BehindTheMath merged 2 commits from fix/form-option-element into master 2018-05-30 14:39:09 -05:00
Conversation 2 Commits 2 Files Changed 1 +2 -2
BehindTheMath commented 2018-05-29 21:29:41 -05:00 (Migrated from github.com)
Copy Link

  • Fix a bug where the value of <option> would not get sent if falsy

    According to the spec, the value attribute should be sent if it exists, even if it's falsy.

  • Don't send an <option> tag if it's disabled, even if it's selected.

Fixes #158.

* Fix a bug where the value of `<option>` would not get sent if falsy According to the spec, the value attribute should be sent if it exists, even if it's falsy. * Don't send an `<option>` tag if it's disabled, even if it's selected. Fixes #158.
robinnorth (Migrated from github.com) reviewed 2018-05-29 21:29:41 -05:00
robinnorth commented 2018-05-30 04:36:30 -05:00 (Migrated from github.com)
Copy Link

LGTM 👍

LGTM 👍
Sign in to join this conversation.
Reviewers
No Reviewers
robinnorth
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
iLoveElysia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#162
Delete Branch "fix/form-option-element"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?