iLoveElysia/pjax
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

loadUrl enhancements #134

Merged
robinnorth merged 2 commits from feature/loadurl-enhancements into master 2018-03-06 05:06:39 -05:00
Conversation 3 Commits 2 Files Changed 15 +148 -62
robinnorth commented 2018-03-04 11:03:50 -05:00 (Migrated from github.com)
Copy Link
  • Make options parameter optional
  • Allow partial overriding of instance options when calling loadUrl directly
  • Make requestOptions optional
  • Document loadUrl usage and provide examples

Closes #130

- Make `options` parameter optional - Allow partial overriding of instance options when calling `loadUrl` directly - Make `requestOptions` optional - Document `loadUrl` usage and provide examples Closes #130
BehindTheMath (Migrated from github.com) reviewed 2018-03-04 22:21:56 -05:00
README.md
BehindTheMath (Migrated from github.com) commented 2018-03-04 22:21:56 -05:00
Copy Link

Should (options) be [options] to signify it's optional?

Should `(options)` be `[options]` to signify it's optional?
robinnorth (Migrated from github.com) reviewed 2018-03-05 04:32:22 -05:00
README.md
robinnorth (Migrated from github.com) commented 2018-03-05 04:32:22 -05:00
Copy Link

That's what the extra brackets are for, but will change to the JSDoc syntax.

That's what the extra brackets are for, but will change to the JSDoc syntax.
BehindTheMath (Migrated from github.com) approved these changes 2018-03-05 22:09:13 -05:00
Sign in to join this conversation.
Reviewers
No Reviewers
robinnorth
BehindTheMath
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
invalid
question
wontfix
No Label
Milestone
No items
No Milestone 0.2.6
Projects
Clear projects
No project
Assignees
Clear assignees
iLoveElysia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#134
Delete Branch "feature/loadurl-enhancements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?