iLoveElysia/pjax
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

Minify pjax.js #108

New Issue
Closed
opened 2018-01-18 15:59:25 -05:00 by BehindTheMath · 5 comments
BehindTheMath commented 2018-01-18 15:59:25 -05:00 (Migrated from github.com)
Copy link
Copy source

We should add a minified version of pjax.js to the NPM package, to reduce the bandwith required for anyone linking to it directly (using unpkg.com).

We should add a minified version of `pjax.js` to the NPM package, to reduce the bandwith required for anyone linking to it directly (using unpkg.com).
jimaek commented 2018-01-18 16:12:43 -05:00 (Migrated from github.com)
Copy link
Copy source

jsDelivr can auto-minify css and js files. Check it out http://cdn.jsdelivr.net/npm/pjax@0.2.4/pjax.min.js

jsDelivr can auto-minify css and js files. Check it out http://cdn.jsdelivr.net/npm/pjax@0.2.4/pjax.min.js
BehindTheMath commented 2018-01-18 16:16:05 -05:00 (Migrated from github.com)
Copy link
Copy source

Cool. Maybe we should suggest this in the README for the unminified version as well, instead of Unpkg.

Cool. Maybe we should suggest this in the README for the unminified version as well, instead of Unpkg.
👍 1
MoOx commented 2018-01-19 01:00:57 -05:00 (Migrated from github.com)
Copy link
Copy source

Can be added to npm package, but imo should not be versionned (can quickly become a pain to maintain). You can exclude with gitignore but include with npm package.json/files section.

Can be added to npm package, but imo should not be versionned (can quickly become a pain to maintain). You can exclude with gitignore but include with npm package.json/files section.
BehindTheMath commented 2018-01-19 01:03:42 -05:00 (Migrated from github.com)
Copy link
Copy source

but imo should not be versionned

Do you mean it shouldn't be committed to Github?

>but imo should not be versionned Do you mean it shouldn't be committed to Github?
MoOx commented 2018-01-19 01:04:33 -05:00 (Migrated from github.com)
Copy link
Copy source

Exactly.

Exactly.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
invalid
question
wontfix
No labels enhancement
Milestone
No items
No Milestone 0.2.5
Projects
Clear projects
No projects
Assignees
Clear assignees
iLoveElysia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: iLoveElysia/pjax#108