From f559ca29149977d94cd5b12ef08a5027626ca5c8 Mon Sep 17 00:00:00 2001 From: Robin North Date: Mon, 22 Jan 2018 19:06:45 +0000 Subject: [PATCH] Cleanup default analytics function --- index.js | 4 +++- lib/proto/parse-options.js | 6 ------ 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/index.js b/index.js index e8ca6e6..8499ff3 100644 --- a/index.js +++ b/index.js @@ -272,7 +272,9 @@ Pjax.prototype = { // Fire Events trigger(document,"pjax:complete pjax:success", state.options) - state.options.analytics() + if (typeof state.options.analytics === "function") { + state.options.analytics() + } if (state.options.history) { // First parse url and check for hash to override scroll diff --git a/lib/proto/parse-options.js b/lib/proto/parse-options.js index 37c16c7..2d89b99 100644 --- a/lib/proto/parse-options.js +++ b/lib/proto/parse-options.js @@ -10,9 +10,6 @@ module.exports = function(options) { this.options.switchesOptions = this.options.switchesOptions || {} this.options.history = this.options.history || true this.options.analytics = this.options.analytics || function() { - // options.backward or options.foward can be true or undefined - // by default, we do track back/foward hit - // https://productforums.google.com/forum/#!topic/analytics/WVwMDjLhXYk if (window._gaq) { _gaq.push(["_trackPageview"]) } @@ -36,7 +33,4 @@ module.exports = function(options) { if (!this.options.switches.body) { this.options.switches.body = defaultSwitches.switchElementsAlt } - if (typeof options.analytics !== "function") { - options.analytics = function() {} - } }