From 8abb21e1e9d899217b03c489c9b2d9ecd92074b5 Mon Sep 17 00:00:00 2001
From: BehindTheMath <BehindTheMath@users.noreply.github.com>
Date: Wed, 30 May 2018 15:39:08 -0400
Subject: [PATCH] Fix parsing values of option elements in forms (#162)

* Fix a bug where the value of <option> would not get sent if falsy

According to the spec, the value attribute should be sent if it
exists, even if it's falsy.

* Don't send an <option> tag if it's disabled, even if it's selected
---
 lib/proto/attach-form.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/proto/attach-form.js b/lib/proto/attach-form.js
index 44c4d48..39333a2 100644
--- a/lib/proto/attach-form.js
+++ b/lib/proto/attach-form.js
@@ -67,8 +67,8 @@ function parseFormElements(el) {
 
           for (var i = 0; i < element.options.length; i++) {
             opt = element.options[i]
-            if (opt.selected) {
-              values.push(opt.value || opt.text)
+            if (opt.selected && !opt.disabled) {
+              values.push(opt.hasAttribute("value") ? opt.value : opt.text)
             }
           }
         }