iLoveElysia/pjax
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

fixing issues with parse-options and related tests

Browse Source
This commit is contained in:
Isaac Gierard
2014-11-20 16:21:19 -08:00
parent d4ba34e5ed
commit 7e81f791a9
3 changed files with 40 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
index.js
View File

@@ -1,4 +1,3 @@
/* global _gaq: true, ga: true */
var newUid = require("./lib/uniqueid.js") var newUid = require("./lib/uniqueid.js")

4
lib/proto/parse-options.js
View File

@@ -1,4 +1,6 @@
module.exports = function parseOptions(options){ /* global _gaq: true, ga: true */
module.exports = function(options){
this.options = options this.options = options
this.options.elements = this.options.elements || "a[href], form[action]" this.options.elements = this.options.elements || "a[href], form[action]"
this.options.selectors = this.options.selectors || ["title", ".js-Pjax"] this.options.selectors = this.options.selectors || ["title", ".js-Pjax"]

68
tests/lib/proto/parse-options.js
View File

@@ -1,6 +1,6 @@
var tape = require("tape") var tape = require("tape")
var parseOptions = require("../../../lib/proto/parse-options") var parseOptions = require("../../../lib/proto/parse-options.js")
tape("test parse initalization options function", function(t) { tape("test parse initalization options function", function(t) {
// via http://stackoverflow.com/questions/1173549/how-to-determine-if-an-object-is-an-object-literal-in-javascript // via http://stackoverflow.com/questions/1173549/how-to-determine-if-an-object-is-an-object-literal-in-javascript
function isObjLiteral(_obj) { function isObjLiteral(_obj) {
@@ -21,46 +21,52 @@ tape("test parse initalization options function", function(t) {
} }
function enumerableKeys(_obj) { function enumerableKeys(_obj) {
var c = 0; var c = 0;
for(var n in _obj){ c++; } for(var n in _obj){ n = n; c++; }
return cl return c;
} }
t.test("- default options", function(t){
var body_1 = {}; var body_1 = {};
var options_1 = {}; var options_1 = {};
parseOptions.apply(body_1,options_1); parseOptions.apply(body_1,[options_1]);
t.deepEqual(body_1.options.elements,"a[href], form[action]"); t.deepEqual(body_1.options.elements,"a[href], form[action]");
t.deepEqual(body_1.options.selectors.length,2); t.deepEqual(body_1.options.selectors.length,2,"selectors length");
t.deepEqual(body_1.options.selectors[0],"title"); t.deepEqual(body_1.options.selectors[0],"title");
t.deepEqual(body_1.options.selectors[0],".js-Pjax"); t.deepEqual(body_1.options.selectors[1],".js-Pjax");
t.deepEqual(isObjLiteral(body_1.options.switches),true); t.deepEqual(isObjLiteral(body_1.options.switches),true);
t.deepEqual(enumerableKeys(body_1.options.switches),0); t.deepEqual(enumerableKeys(body_1.options.switches),2);//head and body
t.deepEqual(isObjLiteral(body_1.options.switchesOptions),true); t.deepEqual(isObjLiteral(body_1.options.switchesOptions),true);
t.deepEqual(enumerableKeys(body_1.options.switchesOptions),0); t.deepEqual(enumerableKeys(body_1.options.switchesOptions),0);
t.deepEqual(body_1.options.history,true); t.deepEqual(body_1.options.history,true);
//TODO analytics is a little weird right now //TODO analytics is a little weird right now
t.deepEqual(typeof body_1.options.analytics,"function"); t.deepEqual(typeof body_1.options.analytics,"function");
t.deepEqual(body_1.options.scrollTo,0); t.deepEqual(body_1.options.scrollTo,0);
t.deepEqual(body_1.options.debug,false); t.deepEqual(body_1.options.debug,false);
t.end();
});
//verify analytics always ends up as a function even when passed not a function //verify analytics always ends up as a function even when passed not a function
var body_2 = {}; t.test("- analytics is a function", function(t){
var options_2 = {analytics:"some string"}; var body_2 = {};
parseOptions.apply(body_2,options_2); var options_2 = {analytics:"some string"};
parseOptions.apply(body_2,[options_2]);
t.deepEqual(typeof body_2.options.analytics,"function");
t.deepEqual(typeof body_2.options.analytics,"function");
t.end();
});
//verify that the value false for scrollTo is not squashed //verify that the value false for scrollTo is not squashed
var body_3 = {}; t.test("- scrollTo remains false", function(t){
var options_3 = {scrollTo:false}; var body_3 = {};
parseOptions.apply(body_3,options_3); var options_3 = {scrollTo:false};
parseOptions.apply(body_3,[options_3]);
t.deepEqual( body_2.options.scrollTo,false);
t.deepEqual( body_3.options.scrollTo,false);
t.end();
});
t.end() t.end()
}) })