iLoveElysia/pjax
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

Cleanup parse-options tests

Browse Source 
- Rename objects for clarity and inline unneeded objects
- Remove unneeded tests
- Use Object.keys().length instead of a custom function
- Use typeof === "object" instead of a custom function that checks
  the prototype tree as well, since we don't expect anything but an
  object literal.
This commit is contained in:
Behind The Math
2018-01-29 23:24:22 -05:00
committed by Robin North
parent 6fb509a021
commit 7ca1d4c2c8
1 changed files with 27 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

79
tests/lib/proto/parse-options.js
View File

@@ -2,72 +2,47 @@ var tape = require("tape")
var parseOptions = require("../../../lib/proto/parse-options.js") var parseOptions = require("../../../lib/proto/parse-options.js")
tape("test parse initalization options function", function(t) { tape("test parse initalization options function", function(t) {
// via http://stackoverflow.com/questions/1173549/how-to-determine-if-an-object-is-an-object-literal-in-javascript
function isObjLiteral(_obj) {
var _test = _obj;
return (typeof _obj !== "object" || _obj === null ?
false :
(
(function() {
while (!false) {
if (Object.getPrototypeOf(_test = Object.getPrototypeOf(_test)) === null) {
break;
}
}
return Object.getPrototypeOf(_obj) === _test;
})()
)
);
}
function enumerableKeys(_obj) {
var c = 0;
for (var n in _obj) {
n = n;
c++;
}
return c;
}
t.test("- default options", function(t) { t.test("- default options", function(t) {
var body1 = {}; var pjax = {};
var options1 = {}; parseOptions.call(pjax, {});
parseOptions.apply(body1, [options1]);
t.equal(body1.options.elements, "a[href], form[action]"); t.equal(pjax.options.elements, "a[href], form[action]");
t.equal(body1.options.selectors.length, 2, "selectors length"); t.equal(pjax.options.selectors.length, 2, "selectors length");
t.equal(body1.options.selectors[0], "title"); t.equal(pjax.options.selectors[0], "title");
t.equal(body1.options.selectors[1], ".js-Pjax"); t.equal(pjax.options.selectors[1], ".js-Pjax");
t.equal(isObjLiteral(body1.options.switches), true);
t.equal(enumerableKeys(body1.options.switches), 2);// head and body t.equal(typeof pjax.options.switches, "object");
t.equal(isObjLiteral(body1.options.switchesOptions), true); t.equal(Object.keys(pjax.options.switches).length, 2);// head and body
t.equal(enumerableKeys(body1.options.switchesOptions), 0);
t.equal(body1.options.history, true); t.equal(typeof pjax.options.switchesOptions, "object");
t.equal(typeof body1.options.analytics, "function"); t.equal(Object.keys(pjax.options.switchesOptions).length, 0);
t.equal(body1.options.scrollTo, 0);
t.equal(body1.options.scrollRestoration, true); t.equal(pjax.options.history, true);
t.equal(body1.options.cacheBust, true); t.equal(typeof pjax.options.analytics, "function");
t.equal(body1.options.debug, false); t.equal(pjax.options.scrollTo, 0);
t.equal(pjax.options.scrollRestoration, true);
t.equal(pjax.options.cacheBust, true);
t.equal(pjax.options.debug, false);
t.end(); t.end();
}); });
// verify analytics always ends up as a function even when passed not a function // verify analytics always ends up as a function even when passed not a function
t.test("- analytics is a function", function(t) { t.test("- analytics is a function", function(t) {
var body2 = {}; var pjax = {};
var options2 = {analytics: "some string"}; parseOptions.call(pjax, {analytics: "some string"});
parseOptions.apply(body2, [options2]);
t.deepEqual(typeof body2.options.analytics, "function"); t.deepEqual(typeof pjax.options.analytics, "function");
t.end(); t.end();
}); });
// verify that the value false for scrollTo is not squashed // verify that the value false for scrollTo is not squashed
t.test("- scrollTo remains false", function(t) { t.test("- scrollTo remains false", function(t) {
var body3 = {}; var pjax = {};
var options3 = {scrollTo: false}; parseOptions.call(pjax, {scrollTo: false});
parseOptions.apply(body3, [options3]);
t.deepEqual(body3.options.scrollTo, false); t.deepEqual(pjax.options.scrollTo, false);
t.end(); t.end();
}); });
t.end() t.end()
}) })